🏃 Add JoelSpeed as reviewer #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
hi, since the bot asked me to take a look, i'm giving a tentative +1 based on your existing work. |
|
+1 from me |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold |
|
+1 |
vincepri
approved these changes
Mar 11, 2020
k8s-ci-robot
added
the
lgtm
|
+1 |
|
+1! |
|
Lazy consensus reached and lots of +1 /hold cancel Welcome @JoelSpeed ! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds me as a reviewer to the project. I've been getting involved in the project for the last couple of months and would like to get more involved where possible. I've touched a reasonably wide area of the code by implementing the MHC project (#1990) and have been trying to review some other PRs as they have been coming in. Hopefully this gives me a good grounding for becoming an effective official reviewer